Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: update nidcpower measurement to support multiple instrument sessions #676

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

jayaseelan-james
Copy link
Contributor

What does this Pull Request accomplish?

Updates the nidcpower_source_dc_voltage measurement to support multiple instrument sessions.

Why should this Pull Request be merged?

Fixes #673.

What testing has been done?

  • Verified the measurement execution in InstrumentStudio using individual site values and "All Sites".
  • Verified the measurement execution in TestStand using sequential and batch process models.

Copy link

github-actions bot commented Mar 25, 2024

Test Results

    30 files  ±0      30 suites  ±0   47m 13s ⏱️ +59s
   639 tests ±0     639 ✅ ±0      0 💤 ±0  0 ❌ ±0 
15 790 runs  ±0  14 730 ✅ ±0  1 060 💤 ±0  0 ❌ ±0 

Results for commit 174a7a3. ± Comparison against base commit 7df2dd8.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dixonjoel dixonjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like you to wait for @bkeryan to review as well.

@jayaseelan-james
Copy link
Contributor Author

jayaseelan-james commented Mar 25, 2024

@dixonjoel @bkeryan I've updated the NI-DCPower example fixing the multiple session issue. With this change, the example has become more complex to support multiple instrument sessions. So, I would like to know if this complexity is fine or if we should leave the example as it was earlier and mention this behavior as a comment in the measurement.

Please let me know your thoughts on this.

Edit: The existing example will work with batch process model execution because each test socket would invoke the measure method individually thereby requiring only a single instrument session per execution.

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

examples/nidcpower_source_dc_voltage/measurement.py Outdated Show resolved Hide resolved
@dixonjoel dixonjoel merged commit 704ccc9 into main Mar 26, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/jay/update-nidcpower-measurement branch March 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running DC Power example with multi-site pin map and 'All sites' selected
3 participants