-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: update nidcpower measurement to support multiple instrument sessions #676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like you to wait for @bkeryan to review as well.
@dixonjoel @bkeryan I've updated the NI-DCPower example fixing the multiple session issue. With this change, the example has become more complex to support multiple instrument sessions. So, I would like to know if this complexity is fine or if we should leave the example as it was earlier and mention this behavior as a comment in the measurement. Please let me know your thoughts on this. Edit: The existing example will work with batch process model execution because each test socket would invoke the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions
What does this Pull Request accomplish?
Updates the
nidcpower_source_dc_voltage
measurement to support multiple instrument sessions.Why should this Pull Request be merged?
Fixes #673.
What testing has been done?