Add Plug-in Library installs scripts to the examples #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
approved these changes
Jul 11, 2024
dixonjoel
approved these changes
Jul 11, 2024
dixonjoel
pushed a commit
that referenced
this pull request
Jul 11, 2024
Merged
1 task
dixonjoel
added a commit
that referenced
this pull request
Jul 12, 2024
…the examples (#789)' (#792) Add Plug-in Library installs scripts to the examples (#789) Co-authored-by: Nick Beer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds install scripts and updates the
.serviceconfigfiles for all the examples.Why should this Pull Request be merged?
Pulling a plug-in from a Plug-in Library will cause DiscoveryService to "install" the plug-in - if an install script is specified. In order to get
poetryto install the python dependencies for these examples, we're adding install scripts for them all.What testing has been done?
Verified the examples work as expected.