Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enumerate services API #826

Merged

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

What does this Pull Request accomplish?

  • Implementation of the enumerate service API, which return the active measurement services
  • Added automation test

Why should this Pull Request be merged?

What testing has been done?

Existing and new automated tests passed.

Copy link

github-actions bot commented Aug 2, 2024

Test Results

    30 files  ± 0      30 suites  ±0   45m 26s ⏱️ + 6m 26s
   646 tests + 3     646 ✅ + 3      0 💤 ±0  0 ❌ ±0 
16 000 runs  +90  14 930 ✅ +90  1 070 💤 ±0  0 ❌ ±0 

Results for commit f85bfd7. ± Comparison against base commit 2d5742a.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion

packages/service/tests/unit/test_discovery_client.py Outdated Show resolved Hide resolved
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal force-pushed the users/jothees/enumerate-service-implementation branch from 04ee409 to 1a02767 Compare August 6, 2024 05:49
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal merged commit f4043fe into main Aug 6, 2024
17 checks passed
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal deleted the users/jothees/enumerate-service-implementation branch September 13, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants