Create Measurement Plug-In Client generator using One line approach #841

Jotheeswaran-Nandagopal · 2024-08-14T11:51:36Z

This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Re-structured the Measurement Plugin SDK generator folder .
Added ni-measurement-plugin-client-generator command.
Implemented one-line approach (creation of a Measurement Plug-In client-module with a single-line command) for Measurement Plug-in Client generation. [Enum support is not included in this implementation, whereas other datatypes - Integer, Float, Double, String, Arrays, Path, IO Resource, Pin and Doublexydatatypes are supported ]
Implemented Measure API in Measurement Plug-in Client
Added acceptance testing for the Measurement Plug-in Client generation

Why should this Pull Request be merged?

Implemented Measurement Plug-in Client generation and Measure API for the users to interact with measurement in CLI

What testing has been done?

Manually created Measurement Plug-in Client and tested
Executed existing and new automated tests

github-actions · 2024-08-14T11:53:04Z

Test Results

30 files ±0 30 suites ±0 41m 12s ⏱️ + 4m 12s
648 tests ±0 648 ✅ ±0 0 💤 ±0 0 ❌ ±0
16 060 runs ±0 14 990 ✅ ±0 1 070 💤 ±0 0 ❌ ±0

Results for commit dfdf3f8. ± Comparison against base commit 55a4ad7.

♻️ This comment has been updated with latest results.

...es/generator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_generator/__main__.py

packages/generator/tests/acceptance/test_generator.py

...tor/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/_constants.py

packages/generator/tests/acceptance/test_client_generator.py

jayaseelan-james

I've only made it to the _support.py file. I'll look into the remaining files on Friday.

...tor/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/_constants.py

...rator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/_support.py

bkeryan

FYI, I'm still not done with my initial review of this PR.

...rator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/_support.py

...tor/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/_constants.py

...rator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/_support.py

...generator/ni_measurement_plugin_client_generator/templates/measurement_plugin_client.py.mako

bkeryan

I still need to review the tests.

...rator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/_support.py

...rator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/template.py

...rator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/_support.py

...ement_plugin_sdk_generator/ni_measurement_plugin_client_generator/templates/_helpers.py.mako

...generator/ni_measurement_plugin_client_generator/templates/measurement_plugin_client.py.mako

packages/generator/pyproject.toml

bkeryan

I think I'm done with the 1st round of review.

packages/generator/tests/conftest.py

packages/generator/tests/acceptance/test_client_generator.py

...generator/ni_measurement_plugin_client_generator/templates/measurement_plugin_client.py.mako

...rator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/template.py

...generator/ni_measurement_plugin_client_generator/templates/measurement_plugin_client.py.mako

packages/generator/tests/acceptance/test_client_generator.py

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako

...rator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_client_generator/template.py

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako

packages/generator/tests/acceptance/test_client_generator.py

packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako

packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py

packages/service/ni_measurement_plugin_sdk_service/parameter/__init__.py

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako

...generator/ni_measurement_plugin_client_generator/templates/measurement_plugin_client.py.mako

packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py

packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py

packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako

packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py

...rator/tests/test_assets/example_renders/measurement_plugin_client/test_measurement_client.py

packages/service/tests/utilities/measurements/test_measurement/__init__.py

Jotheeswaran-Nandagopal requested review from csjall, dixonjoel, bkeryan, mshafer-NI and nstokes-nati as code owners August 14, 2024 11:51

Jotheeswaran-Nandagopal requested review from Avinash2Suresh and jayaseelan-james August 14, 2024 11:52

Jotheeswaran-Nandagopal force-pushed the users/jothees/measurement-client-one-line-approach branch from 0c431e5 to 7e70e38 Compare August 14, 2024 12:59

Jotheeswaran-Nandagopal changed the title ~~Create Measurement Plugin Client generator using One line approach~~ Create Measurement Plug-In Client generator using One line approach Aug 14, 2024

bkeryan requested changes Aug 14, 2024

View reviewed changes

...es/generator/ni_measurement_plugin_sdk_generator/ni_measurement_plugin_generator/__main__.py Outdated Show resolved Hide resolved

bkeryan requested changes Aug 14, 2024

View reviewed changes

jayaseelan-james reviewed Aug 14, 2024

View reviewed changes

bkeryan requested changes Aug 14, 2024

View reviewed changes

bkeryan reviewed Aug 15, 2024

View reviewed changes

bkeryan requested changes Aug 15, 2024

View reviewed changes

Jotheeswaran-Nandagopal requested review from jayaseelan-james and bkeryan August 19, 2024 13:34

bkeryan reviewed Aug 19, 2024

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal added 11 commits August 20, 2024 16:26

update : change the plugin generator files to separate folder

81eba0f

fix : resolve formatting

8fe0744

feat : add changes to client template

7d48408

feat : add template creation implementation

228b0f3

feat : measurement plugin client generator

dfa65d3

fix : resolve formatting and lint issues

32cbd19

fix : add exception handling

b5c42b0

update poetry lock

cbc24c6

fix : resolve issues due to merge

1e2b815

fix : pr build and restructure folder

44f2a66

fix : resolve comments

9f8d977

refactor: remove unused import

c1c9c9b

Jotheeswaran-Nandagopal requested a review from jayaseelan-james August 23, 2024 13:51

bkeryan requested changes Aug 24, 2024

View reviewed changes

fix : resolve comments

5e9a099

Jotheeswaran-Nandagopal requested a review from bkeryan August 27, 2024 13:17

fix : pipeline failure

648b1f8

bkeryan requested changes Aug 28, 2024

View reviewed changes

bkeryan reviewed Aug 28, 2024

View reviewed changes

packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal added 4 commits August 28, 2024 09:42

fix : resolve comments

13dc609

refactor : formatting

7eb96e2

fix : add regex to validate class name

87f1d09

fix : update error messages

3dc1062

Jotheeswaran-Nandagopal requested a review from bkeryan August 28, 2024 11:31

fix : update validation

1527c59

bkeryan reviewed Aug 28, 2024

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

This was referenced Aug 28, 2024

Python measurement services tolerate incorrect type_url #850

Closed

Measurement client generator does not work with C# services #851

Closed

bkeryan approved these changes Aug 28, 2024

View reviewed changes

jayaseelan-james requested changes Aug 29, 2024

View reviewed changes

Jotheeswaran-Nandagopal added 4 commits August 29, 2024 15:30

fix: resolve comments

b5a626d

refactor: update doc

73b7b44

fix: formatting

c5cef92

fix: formatting

dfdf3f8

Jotheeswaran-Nandagopal requested a review from jayaseelan-james August 29, 2024 11:54

fix: remove constants.py

6b7b29d

jayaseelan-james approved these changes Aug 29, 2024

View reviewed changes

Jotheeswaran-Nandagopal merged commit 84af8a7 into main Aug 29, 2024
15 checks passed

Jotheeswaran-Nandagopal mentioned this pull request Sep 4, 2024

Provide naming guidelines for Service Class in documentation #873

Open

bkeryan mentioned this pull request Sep 10, 2024

Added Register Pin Map API to Measurement Client #871

Merged

1 task

Jotheeswaran-Nandagopal deleted the users/jothees/measurement-client-one-line-approach branch September 13, 2024 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Measurement Plug-In Client generator using One line approach #841

Create Measurement Plug-In Client generator using One line approach #841

Jotheeswaran-Nandagopal commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

jayaseelan-james left a comment

bkeryan left a comment

bkeryan left a comment

bkeryan left a comment

Create Measurement Plug-In Client generator using One line approach #841

Create Measurement Plug-In Client generator using One line approach #841

Conversation

Jotheeswaran-Nandagopal commented Aug 14, 2024 • edited Loading

What does this Pull Request accomplish?

Why should this Pull Request be merged?

What testing has been done?

github-actions bot commented Aug 14, 2024 • edited Loading

Test Results

jayaseelan-james left a comment

Choose a reason for hiding this comment

bkeryan left a comment

Choose a reason for hiding this comment

bkeryan left a comment

Choose a reason for hiding this comment

bkeryan left a comment

Choose a reason for hiding this comment

Jotheeswaran-Nandagopal commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading