Add Pin Map Client to Measurement PlugIn SDK Service #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounikaBattu17
requested review from
csjall,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
MounikaBattu17
commented
Aug 29, 2024
packages/service/tests/assets/unit/pin_map/1Smu1ChannelGroup1Pin1Site.pinmap
Outdated
Show resolved
Hide resolved
bkeryan
requested changes
Aug 29, 2024
packages/service/ni_measurement_plugin_sdk_service/pin_map/_client.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/pin_map/_client.py
Outdated
Show resolved
Hide resolved
bkeryan
reviewed
Aug 29, 2024
dixonjoel
approved these changes
Aug 30, 2024
bkeryan
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
As we need pin map client in Measurement Client, adding Pin Map Client to Measurement PlugIn SDK Service.
Why should this Pull Request be merged?
pin_map_client.pyfromtest_utilitiesto the newly created module.PinMapClient.What testing has been done?
Added automated tests.