-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for measurements with no output configuration in client generation acceptance test #900
Merged
Jotheeswaran-Nandagopal
merged 5 commits into
main
from
users/jothees/test-void-measurement
Sep 20, 2024
Merged
Add test case for measurements with no output configuration in client generation acceptance test #900
Jotheeswaran-Nandagopal
merged 5 commits into
main
from
users/jothees/test-void-measurement
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jotheeswaran-Nandagopal
requested review from
jayaseelan-james and
Avinash2Suresh
September 19, 2024 08:32
Jotheeswaran-Nandagopal
requested review from
csjall,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
September 19, 2024 08:32
Test Results 40 files ± 0 40 suites ±0 49m 56s ⏱️ - 5m 8s Results for commit 685b62d. ± Comparison against base commit ac3d5b1. This pull request removes 5 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
...rator/tests/test_assets/example_renders/measurement_plugin_client/void_measurement_client.py
Show resolved
Hide resolved
bkeryan
requested changes
Sep 19, 2024
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako
Outdated
Show resolved
Hide resolved
bkeryan
approved these changes
Sep 19, 2024
Jotheeswaran-Nandagopal
deleted the
users/jothees/test-void-measurement
branch
September 20, 2024 05:58
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
test_client_generator.py
.mako
, to remove missing imports during the generation of measurements with no output configuration.mako
.Why should this Pull Request be merged?
mako
. As, some imports are unused in the client module for the measurements with no output configuration.pathlib
is already added inmako
, also, we are addingpathlib
, during client creation of measurement with path configurations.What testing has been done?