Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for measurements with no output configuration in client generation acceptance test #900

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

What does this Pull Request accomplish?

  • Added a measurement with no output configurations to test utilities.
  • Added a test case for measurements with no output configuration in test_client_generator.py.
  • Added a if condition in mako, to remove missing imports during the generation of measurements with no output configuration.
  • Remove duplicate imports in mako.

Why should this Pull Request be merged?

  • Added a new test case to verify the client generation for the measurements with no output configuration.
  • Handle unused imports in mako. As, some imports are unused in the client module for the measurements with no output configuration.
  • Remove duplicate imports i.e., Path is imported twice, as pathlib is already added in mako, also, we are adding pathlib, during client creation of measurement with path configurations.

What testing has been done?

  • Existing and new automation tests passed.

Copy link

github-actions bot commented Sep 19, 2024

Test Results

    40 files  ± 0      40 suites  ±0   49m 56s ⏱️ - 5m 8s
   689 tests + 1     689 ✅ + 1      0 💤 ±0  0 ❌ ±0 
16 790 runs  +10  15 720 ✅ +10  1 070 💤 ±0  0 ❌ ±0 

Results for commit 685b62d. ± Comparison against base commit ac3d5b1.

This pull request removes 5 and adds 6 tests. Note that renamed tests count towards both.
tests.acceptance.test_client_generator ‑ test___command_line_args___create_client___render_with_proper_line_ending
tests.acceptance.test_client_generator ‑ test___command_line_args___create_client___render_without_error
tests.acceptance.test_client_generator ‑ test___command_line_args___create_client_for_all_registered_measurements___renders_without_error
tests.acceptance.test_client_generator ‑ test___command_line_args_with_registered_measurements___create_client_using_interactive_mode___renders_without_error
tests.acceptance.test_client_generator ‑ test___command_line_args_without_registering_any_measurement___create_client_using_interactive_mode___raises_exception
tests.acceptance.test_client_generator ‑ test___all_registered_measurements___create_client___renders_without_error
tests.acceptance.test_client_generator ‑ test___interactive_mode_with_registered_measurements___create_client___renders_without_error
tests.acceptance.test_client_generator ‑ test___interactive_mode_without_registered_measurements___create_client___raises_exception
tests.acceptance.test_client_generator ‑ test___non_streaming_measurement___create_client___render_with_proper_line_ending
tests.acceptance.test_client_generator ‑ test___non_streaming_measurement___create_client___render_without_error
tests.acceptance.test_client_generator ‑ test___void_measurement___create_client___render_without_error

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants