Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not specify version in the MeasurementService constructor #907

Merged
merged 9 commits into from
Sep 22, 2024

Conversation

dixonjoel
Copy link
Collaborator

@dixonjoel dixonjoel commented Sep 20, 2024

What does this Pull Request accomplish?

Specified the same version 1.0.0.0 for all examples in measurement.py and .serviceconfig file.

Why should this Pull Request be merged?

With 2.1.0-dev0 or greater, this version will be used to register the service. Many of the examples were using '0.1.0.0'. When TestStand tries to access a measurement, it uses '1.0.0' for the default version. So we could specify 1.0.0.0 in the .serviceconfig file and / or we could do this.

What testing has been done?

Testing the installed examples locally.

@dixonjoel dixonjoel requested a review from bkeryan September 20, 2024 21:59
Copy link

github-actions bot commented Sep 20, 2024

Test Results

    40 files  ±0      40 suites  ±0   49m 32s ⏱️ -23s
   689 tests ±0     689 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 790 runs  ±0  15 720 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit 7c0cb39. ± Comparison against base commit 82ab553.

♻️ This comment has been updated with latest results.

@bkeryan
Copy link
Collaborator

bkeryan commented Sep 20, 2024

The test failure looks like flakiness in one of the new client cancellation tests:

================================== FAILURES ===================================
____ test___streaming_measurement_execution___cancel___cancels_measurement ____

measurement_plugin_client_module = <module 'test_measurement_client.py' from 'C:\\Users\\ec2-user\\AppData\\Local\\Temp\\pytest-of-unknown\\pytest-5\\measurement_plugin_client_files7\\test_measurement_client.py'>

    def test___streaming_measurement_execution___cancel___cancels_measurement(
        measurement_plugin_client_module: ModuleType,
    ) -> None:
        test_measurement_client_type = getattr(measurement_plugin_client_module, "TestMeasurement")
        measurement_plugin_client = test_measurement_client_type()
    
        with pytest.raises(grpc.RpcError) as exc_info:
            with concurrent.futures.ThreadPoolExecutor() as executor:
                measure = executor.submit(lambda: list(measurement_plugin_client.stream_measure()))
                measurement_plugin_client.cancel()
>               measure.result()
E               Failed: DID NOT RAISE <class 'grpc.RpcError'>

C:\actions-runner\1\_work\measurement-plugin-python\measurement-plugin-python\packages\generator\tests\acceptance\test_streaming_measurement_client.py:96: Failed

I filed #910 and reran the PR checks.

@dixonjoel dixonjoel merged commit 10328bb into main Sep 22, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/stop-specifying-version branch September 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants