-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not specify version in the MeasurementService constructor #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixonjoel
requested review from
csjall,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
September 20, 2024 19:59
bkeryan
requested changes
Sep 20, 2024
bkeryan
reviewed
Sep 20, 2024
bkeryan
approved these changes
Sep 20, 2024
The test failure looks like flakiness in one of the new client cancellation tests:
I filed #910 and reran the PR checks. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Specified the same version 1.0.0.0 for all examples in measurement.py and .serviceconfig file.
Why should this Pull Request be merged?
With 2.1.0-dev0 or greater, this version will be used to register the service. Many of the examples were using '0.1.0.0'. When TestStand tries to access a measurement, it uses '1.0.0' for the default version. So we could specify 1.0.0.0 in the .serviceconfig file and / or we could do this.
What testing has been done?
Testing the installed examples locally.