[releases/2.1] Cherry-pick: Update version checking to warn that version is deprecated and error if there is no .serviceconfig version #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
…if there is no .serviceconfig version (#911) * Update version checking to warn that version is deprecated and to ensure that there is a version in the .serviceconfig file * Fix lint error * Update error message to mention version field in .serviceconfig * Fix assert * Fix lint errors * Remove RuntimeError * Use empty string * Fix test to not expect RuntimeError * Fix formatting (cherry picked from commit 113b166)
bkeryan
force-pushed
the
users/bkeryan/cherry-pick-version-checking
branch
from
baff605 to
b3f6018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Cherry-pick #911 into releases/2.1.