-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generator: Add dependency on service #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider adding the "develop=true" attribute to the NIMS package specified under the dev.dependencies?
Good point. I think that will help. Poetry will install a We were previously doing it this way, but we stopped because it didn't catch erroneous code that accessed files that only exist in Git and not in the distribution package. I guess we'll have to be more careful about that in the future, or reorganize the repo (again) to use the "src" package layout instead of the "flat" package layout. |
* generator: Add dependency on service * generator: Update poetry.lock * generator: Use develop mode to avoid caching service source in the venv (cherry picked from commit cccabe8)
What does this Pull Request accomplish?
Update
ni-measurement-plugin-sdk-generator
to depend onni-measurement-plugin-sdk-service
Update the generator's Poetry dev dependencies to install service in develop mode, in order to avoid saving the service source in the cached venv.
Why should this Pull Request be merged?
It was relying on Poetry dev dependencies. No one tried installing the generator in isolation.
What testing has been done?