-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle unsupported message type errors in client generator #984
Handle unsupported message type errors in client generator #984
Conversation
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestion.
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of code changes I'll look at after they're done.
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
@dixonjoel , @bkeryan |
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
@bkeryan, I have updated the changes. Kindly, help us reviewing the changes at your earliest convenience. |
What does this Pull Request accomplish?
try-except
block to catch the exceptions raised during the creation of multiple clients and for all registered measurements. Also, show warning message about client creation failure and continue client creation for subsequent measurements.Why should this Pull Request be merged?
What testing has been done?