Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unsupported message type errors in client generator #984

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

What does this Pull Request accomplish?

  • Updated the client generator to raise a click exception for unsupported datatypes, by validating the message type after getting the metadata.
  • Added try-except block to catch the exceptions raised during the creation of multiple clients and for all registered measurements. Also, show warning message about client creation failure and continue client creation for subsequent measurements.

Why should this Pull Request be merged?

What testing has been done?

  • Done manual testing
  • Existing automation test passed

Copy link
Contributor

@Avinash2Suresh Avinash2Suresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion.

Copy link

github-actions bot commented Oct 11, 2024

Test Results

    40 files  ±0      40 suites  ±0   49m 54s ⏱️ - 1m 11s
   700 tests ±0     700 ✅ ±0      0 💤 ±0  0 ❌ ±0 
17 000 runs  ±0  15 930 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit 4698bca. ± Comparison against base commit ebe576e.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dixonjoel dixonjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of code changes I'll look at after they're done.

@Jotheeswaran-Nandagopal
Copy link
Contributor Author

@dixonjoel , @bkeryan
I have refactored the code and implemented the requested changes. Please help me reviewing the changes.

@Jothees07
Copy link

@bkeryan, I have updated the changes. Kindly, help us reviewing the changes at your earliest convenience.

@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal merged commit a0cf656 into main Oct 16, 2024
17 checks passed
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal deleted the users/jothees/issue-handle-unsupported-message-type-errors branch October 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants