Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect types in samp_quant_samp_per_chan and total_samp_per_chan_generated parameters #32

Closed
cthomas97 opened this issue Sep 18, 2017 · 1 comment

Comments

@cthomas97
Copy link

Both samp_quant_samp_per_chan and total_samp_per_chan_generated parameters
use c_double types, rather than c_long_long (UInt64) as required by the dll function.
Changing line 949 and 957 in out_stream.py and 2230, 2238 and 2253 in timing.py restores correct operation.

@epage
Copy link

epage commented Sep 20, 2017

Thanks for using nidaqmx and thank you for letting us know of this problem!

For others sake, these are the related lines from NIDAQmx.h

int32 __CFUNC DAQmxGetSampQuantSampPerChan(TaskHandle taskHandle, uInt64 *data);
int32 __CFUNC DAQmxGetWriteTotalSampPerChanGenerated(TaskHandle taskHandle, uInt64 *data);

Wondernutz added a commit that referenced this issue Sep 21, 2017
<rev> Fixing incorrect property data type metadata in the Python DAQmx
API. Raised by issue: #32
<priv> Turns out a number of UInt64 properties had incorrect metadata. I
went through all of the U64 properties in the API and found some others
that were wrong too.

<rev> Working around issue:
#1, where nidaqmx doesn't
work on Python 2.7.13 because of a ctypes bug.

<rev> Changing to install from pypi for nidaqmx_src since installing
from Build Services package dependencies seems broken in newer versions
of pythonservices. We have a requirements file to enforce versions, so
who cares.

<bud> http://review-board.natinst.com/r/202523/
Wondernutz added a commit that referenced this issue Sep 21, 2017
Fix Issue: #32

Left out file whenn submitting previous changelist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants