-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nimble Table: cell view (custom element) and cell state changes #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmithNI
commented
Mar 28, 2023
mollykreis
reviewed
Mar 29, 2023
jattasNI
approved these changes
Mar 29, 2023
packages/nimble-components/src/table/components/row/tests/table-row.spec.ts
Show resolved
Hide resolved
atmgrifter00
approved these changes
Mar 29, 2023
rajsite
reviewed
Mar 30, 2023
packages/nimble-components/src/table-column/text/cell-view/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/text/cell-view/template.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/components/cell/template.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Mar 30, 2023
rajsite
approved these changes
Apr 3, 2023
atmgrifter00
reviewed
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Fixes #997
π©βπ» Implementation
Implementation is similar to what was outlined in the the HLD (PR):
TableCellView<TCellRecord, TColumnConfig>
class. TableCellView instances will be used inTableCell
s, instead of the old approach (column-provided cellTemplate and cellStyles).cellViewTag
property toTableColumn
(links the column with the associatedTableCellView
type)TableCellView
defines afocusedRecycleCallback()
method which is a no-op by default. If a cell view contains a focusable element, and a cell is focused, and then a scroll (row recycle) occurs, this gives the cell view an opportunity to commit/blur/etc.π§ͺ Testing
focusedRecycleCallback
and the code that closes action menus on scrollβ Checklist