Revert icon timing workaround #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2023
|
@jattasNI merging this to disable intermittent tests that are interfering with main. Can address concerns in a follow-up if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
As part of #1156 a change was made to tooltip icon tests to run in Firefox. The implemented solution added arbitrary additional waits which are turning out to be intermittent. This PR disables those tests until a more robust implementation can be found. Additional investigation is being skipped to get main stable at the moment.
Fixes #1166 (fixes the intermittency on main, and #1075 covers fixing the actual disabled tests)
I'm also disabling the intermittent test associated with #1172 as it was causing failues locally trying to reproduce the intermittency of this test.
👩💻 Implementation
Revert the test changes and place them into the existing original bucket of firefox failing tests.
🧪 Testing
Relying on CI
✅ Checklist