Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular and Blazor support for required-visible #2510

Merged
merged 16 commits into from
Jan 8, 2025

Conversation

mollykreis
Copy link
Contributor

Pull Request

🤨 Rationale

As part of #2100, the required-visible configuration needs to be exposed on components through the Angular and Blazor wrappers. This PR adds that support for all components that currently support required-visible (combobox, select, text area, text field, radio group, and number field).

👩‍💻 Implementation

Follow existing patterns for exposing requiredVisible on the 6 components that support it in both Angular and Blazor.

🧪 Testing

New unit tests following existing patterns.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis mollykreis marked this pull request as ready for review January 8, 2025 19:56
@rajsite
Copy link
Member

rajsite commented Jan 8, 2025

Bypassing blazor owners for straightforward change

@rajsite rajsite merged commit 5f2245f into main Jan 8, 2025
14 checks passed
@rajsite rajsite deleted the framework-required-visible branch January 8, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants