Temporarily disable 'npm audit' on non-production dependencies #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Workaround for #581 to get the pipeline unblocked while we wait for beachball to publish a fix (or try out updating the transitive dependency on
workspace-tools
ourselves within this repo).👩💻 Implementation
Comment out the steps which run
npm audit
inmain.yml
.I thought we could get away with only disabling the non-production configuration of
npm audit
. Butbeachball
(and by extensionworkspace-tools
) is listed inpeerDependencies
of ourbeackball-lock-update
package and it seems thataudit
includes those when running--only=prod
.🧪 Testing
Relying on pipeline.
✅ Checklist