Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable 'npm audit' on non-production dependencies #582

Merged
merged 2 commits into from
May 26, 2022

Conversation

jattasNI
Copy link
Contributor

@jattasNI jattasNI commented May 26, 2022

Pull Request

🤨 Rationale

Workaround for #581 to get the pipeline unblocked while we wait for beachball to publish a fix (or try out updating the transitive dependency on workspace-tools ourselves within this repo).

👩‍💻 Implementation

Comment out the steps which run npm audit in main.yml.

I thought we could get away with only disabling the non-production configuration of npm audit. But beachball (and by extension workspace-tools) is listed in peerDependencies of our beackball-lock-update package and it seems that audit includes those when running --only=prod.

🧪 Testing

Relying on pipeline.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI jattasNI enabled auto-merge (squash) May 26, 2022 18:18
@jattasNI jattasNI merged commit f7602ae into main May 26, 2022
@jattasNI jattasNI deleted the disable-devdeps-audit branch May 26, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants