Nimble tooltip implementation #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
reviewed
Jun 20, 2022
change/@ni-nimble-components-8a80cab3-e911-4d17-8e6e-0626017dc72c.json
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip-matrix.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip-matrix.stories.ts
Outdated
Show resolved
Hide resolved
mollykreis
requested changes
Jun 21, 2022
packages/nimble-components/src/theme-provider/design-token-comments.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip-matrix.stories.ts
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Jun 21, 2022
packages/nimble-components/src/tooltip/tests/tooltip.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip-matrix.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip-matrix.stories.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Jun 21, 2022
rajsite
reviewed
Jun 21, 2022
mollykreis
approved these changes
Jun 23, 2022
packages/nimble-components/src/theme-provider/design-token-comments.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip-matrix.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/tooltip/tests/tooltip.stories.ts
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Jun 23, 2022
rajsite
reviewed
Jun 23, 2022
rajsite
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Initial implementation for nimble-tooltip, intended to get the default tooltip working and implemented. See #309
👩💻 Implementation
Includes only the default tooltip state, with the other states to be implemented in the future. See tooltip spec, API section. Styling and implementation will need to be updated in the future in order to make the error and information states functional. Other questions listed in the open issues section will also be addressed in future updates.
🧪 Testing
Added unit tests and storybook matrix pages.
✅ Checklist