Tooltip angular integration #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar-integration
aidendk
requested review from
rajsite,
atmgrifter00,
jattasNI and
fredvisser
as code owners
mollykreis
reviewed
Jul 28, 2022
angular-workspace/projects/ni/nimble-angular/src/directives/tooltip/nimble-tooltip.directive.ts
Outdated
Show resolved
Hide resolved
angular-workspace/projects/ni/nimble-angular/src/directives/tooltip/nimble-tooltip.directive.ts
Outdated
Show resolved
Hide resolved
...ace/projects/ni/nimble-angular/src/directives/tooltip/tests/nimble-tooltip.directive.spec.ts
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Jul 28, 2022
...ace/projects/ni/nimble-angular/src/directives/tooltip/tests/nimble-tooltip.directive.spec.ts
Outdated
Show resolved
Hide resolved
mollykreis
approved these changes
Jul 29, 2022
rajsite
approved these changes
Jul 29, 2022
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Aug 1, 2022
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html
Outdated
Show resolved
Hide resolved
msmithNI
reviewed
Aug 2, 2022
angular-workspace/projects/ni/nimble-angular/src/directives/tooltip/nimble-tooltip.directive.ts
Show resolved
Hide resolved
msmithNI
approved these changes
Aug 3, 2022
|
@aidendk is there anything left to do for this PR? I noticed all the comments are resolved but it hasn't been merged yet. I don't think you need to wait for either of the remaining reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Integrates the nimble-tooltip (#309) into the Nimble angular-workspace.
👩💻 Implementation
Includes the default, fail, information, fail icon, and information icon states in the custom-app.
🧪 Testing
Tooltip-specific tests are used in the directive.spec.ts file.
✅ Checklist