Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableColumnTextField API #930

Merged
merged 78 commits into from
Jan 5, 2023
Merged

TableColumnTextField API #930

merged 78 commits into from
Jan 5, 2023

Conversation

atmgrifter00
Copy link
Contributor

Pull Request

🤨 Rationale

This is a proposal for the initial API for the column type for displaying text in a table.

atmgrifter00 and others added 30 commits December 6, 2022 14:42
@atmgrifter00
First draft of table column API HLD.
ddd638e
@atmgrifter00
Merge branch 'main' into table-columns-api-hld
3fcb9ab
@atmgrifter00
Change files
200ad12
@atmgrifter00
Grammar.
fec9f1d
@atmgrifter00
Add another example column.
a3853f6
@mollykreis
update typing of table cell data
229756a
@mollykreis
format
f91a451
@mollykreis
Update packages/nimble-components/src/table/specs/table-columns-hld.md
0fa368b 
Co-authored-by: mollykreis <[email protected]>
@atmgrifter00
Handling some PR feedback.
07dfd36
@atmgrifter00
Merge branch 'table-columns-api-hld' of https://github.com/ni/nimble …
043fb1f 
…into table-columns-api-hld
@atmgrifter00
Formatting.
6e273c4
@atmgrifter00
Merge branch 'main' into table-columns-api-hld
df60ab0
@atmgrifter00
Linting.
6b40210
@atmgrifter00
Handle PR feedback.
36282bb
@atmgrifter00
Handling PR feedback.
0d4ce01
@atmgrifter00
Formatting.
4a216ed
Merge branch 'main' into table-columns-api-hld
f4c6608
@atmgrifter00
Adding link.
f80dde0
@atmgrifter00
Updating table spec.
d808ecf
@atmgrifter00
Handling PR feedback.
5318ea2
Merge branch 'main' into table-columns-api-hld
6732237
Merge branch 'main' into table-columns-api-hld
963c6ad
@atmgrifter00
Initial commit
6ff54fb
@mollykreis
Update packages/nimble-components/src/table/specs/table-columns-hld.md
6621b77 
Co-authored-by: mollykreis <[email protected]>
@mollykreis
Update packages/nimble-components/src/table/specs/table-columns-hld.md
7530a8f 
Co-authored-by: mollykreis <[email protected]>
@mollykreis
Update packages/nimble-components/src/table/specs/table-columns-hld.md
da2030c 
Co-authored-by: mollykreis <[email protected]>
@atmgrifter00
Handling PR feedback.
5fb3f60
@atmgrifter00
Merge branch 'table-columns-api-hld' of https://github.com/ni/nimble …
b213db3 
…into table-columns-api-hld
@atmgrifter00
Clean up API a bit.
2f65325
@mollykreis
Update packages/nimble-components/src/table/specs/table-columns-hld.md
bb8f7f2 
Co-authored-by: mollykreis <[email protected]>
@nate-ni nate-ni mentioned this pull request Dec 16, 2022
Closed
@atmgrifter00 atmgrifter00 reopened this Jan 3, 2023
jattasNI
jattasNI reviewed Jan 3, 2023
View reviewed changes
packages/nimble-components/src/table/specs/table-column-specs/table-column-text-field.md Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-text-field.md Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-text-field.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-text-field.md Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-text-field.md Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-text-field.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-text-field.md Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-text-field.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-text-field.md Outdated Show resolved Hide resolved
@atmgrifter00 atmgrifter00 requested a review from jattasNI January 4, 2023 20:53
@atmgrifter00 atmgrifter00 merged commit 7df60e8 into main Jan 5, 2023
@atmgrifter00 atmgrifter00 deleted the table-column-string-api branch January 5, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollykreis mollykreis mollykreis approved these changes

@jattasNI jattasNI jattasNI approved these changes

@rajsite rajsite rajsite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atmgrifter00 @rajsite @jattasNI @mollykreis