Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on major version of DSF custom device #24

Merged
merged 2 commits into from
May 2, 2022

Conversation

buckd
Copy link
Collaborator

@buckd buckd commented Apr 29, 2022

What does this Pull Request accomplish?

Installs the DSF plugins if the major version of DSF custom device (i.e. 21.0.0) is installed instead of depending on a strictly matching version.

Why should this Pull Request be merged?

We're building a new version of the plugins to support RDMA, but do not want to release a new version of the DSF custom device because there are zero changes since the last release.

What testing has been done?

Built PR against build tools PR 130 and verified {major_version} was correctly replaced and the package built.

@buckd buckd requested a review from rtzoeller as a code owner April 29, 2022 20:28
@buckd buckd marked this pull request as draft April 29, 2022 20:30
@buckd buckd marked this pull request as ready for review May 2, 2022 14:30
control_dsf_plugins Outdated Show resolved Hide resolved
@buckd buckd merged commit 230bd73 into main May 2, 2022
@buckd buckd deleted the dev/major_version_support branch May 2, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants