CMake: Enable use of external msquic #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For vcpkg. For #115.
Based on the current HEAD of msquic release/2.4, as referenced in
.gitmodules.The msh3-config.cmake change is not tested in vcpkg because the port only builds a shared lib ATM. However, it is the canonical code for providing the required imported targets when they occurs as a transitive usage requirement for linking. (The msquic targets do not yet carry a CMake namespace. Without find_dependency, CMake would have to pass the target name as a link lib name to the linker, maybe leading to unexpected results.)