Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11 add pre process to resize images in build. #24

Merged
merged 2 commits into from
Feb 4, 2021
Merged

#11 add pre process to resize images in build. #24

merged 2 commits into from
Feb 4, 2021

Conversation

gkmngrgn
Copy link
Contributor

@gkmngrgn gkmngrgn commented Feb 2, 2021

Description

  • updated versions of gatsby-transformer-sharp and gatsby-plugin-sharp.
  • add pre process to resize images in build.
  • correct indentations in component files.

Motivation and context

I've no motivation, I hate JS.

How to test

just run gatsby deploy and disable max-width and max-height features of img style.

Screenshots

image

@gkmngrgn
Copy link
Contributor Author

gkmngrgn commented Feb 3, 2021

@eralpkaraduman do we use netlify build? If so, can you adapt this solution?

gatsbyjs/gatsby#20698 (comment)

@eralpkaraduman
Copy link
Member

@eralpkaraduman do we use netlify build? If so, can you adapt this solution?

gatsbyjs/gatsby#20698 (comment)

let's try rm -rf node_modules rm package-lock.json npm i first, so we try updating the dependency tree. I assume vips installed on ci machine is not matching the one we require.
Builds go faster if we don't ignore the vips installed on netlifys machines

@eralpkaraduman
Copy link
Member

eralpkaraduman commented Feb 4, 2021

Suggesting this change;
updated subdependencies and downgraded sharp related ones.
You can merge this PR onto this PR to get CD working.
https://github.com/gkmngrgn/unhandledexception.club/pull/1

Tried CD on this PR, it was able to build on netlify properly
#27 see the checks at https://github.com/nicework-company/unhandledexception.club/pull/27/checks

Copy link
Member

@eralpkaraduman eralpkaraduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎👌

@eralpkaraduman eralpkaraduman merged commit 12ed62c into nicework-company:main Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants