Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sass division deprecation warning #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

richardwestenra
Copy link

I am getting console warnings (copied below) when importing this project's SCSS file into my next.js project.

Sass currently treats / as a division operation in some contexts and a separator in others. This makes it difficult for Sass users to tell what any given / will mean, and makes it hard to work with new CSS features that use / as a separator.

Sass docs

I've made these changes to hopefully remove this deprecated feature and fix these warnings.

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(12, $mon-pad-cols)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
93 │     $mon-pad-rows: round(12 / $mon-pad-cols);
   │                          ^^^^^^^^^^^^^^^^^^
   ╵
    node_modules/react-month-picker/scss/month-picker.scss 93:26  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, $mon-pad-cols)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
94 │     $mon-option-width: 100% / $mon-pad-cols;
   │                        ^^^^^^^^^^^^^^^^^^^^
   ╵
    node_modules/react-month-picker/scss/month-picker.scss 94:24  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(12, $m-mon-pad-cols)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
96 │     $m-mon-pad-rows: round(12 / $m-mon-pad-cols);
   │                            ^^^^^^^^^^^^^^^^^^^^
   ╵
    node_modules/react-month-picker/scss/month-picker.scss 96:28  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, $m-mon-pad-cols)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
97 │     $m-mon-option-width: 100% / $m-mon-pad-cols;
   │                          ^^^^^^^^^^^^^^^^^^^^^^
   ╵
    node_modules/react-month-picker/scss/month-picker.scss 97:26  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated
and will be removed in Dart Sass 2.0.0.
More info and automated migrator:
https://sass-lang.com/d/slash-div
@richardwestenra
Copy link
Author

@nickeljew Hey are you still maintaining this repo? Do you want/need help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant