Update sortTypealiases rule to support any keyword
#1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Dec 7, 2024
Sources/ParsingHelpers.swift
Outdated
Comment on lines
2217
to
2219
| let andTokenIndices = type.range.filter { index in | ||
| tokens[index] == .operator("&", .infix) | ||
| } |
There was a problem hiding this comment.
This was the problem with the previous approach. We can't just assume that every & in a type is separating elements of a protocol composition.
calda
force-pushed
the
cal--sortTypealiases-any-types
branch
from
2059b37 to
bf72c9c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1938 +/- ##
===========================================
- Coverage 95.18% 95.11% -0.07%
===========================================
Files 137 137
Lines 25094 25125 +31
===========================================
+ Hits 23885 23898 +13
- Misses 1209 1227 +18 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
nicklockwood
pushed a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to the fix for #1929 this PR updates the
sortTypealaisesrule to support theanykeyword.