Get username in case of certificates authentication #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoldr
changed the title
| @@ -9,7 +9,14 @@ | |||
| "realm": "zot", | |||
| "tls": { | |||
| "cert": "test/data/server.cert", | |||
| "key": "test/data/server.key" | |||
| "key": "test/data/server.key", | |||
| "cacert": "test/data/ca.crt" | |||
There was a problem hiding this comment.
remove this changes, no need for them.
There was a problem hiding this comment.
Will remove them when making the PR, thank you!
nicoldr
force-pushed
the
getUsername
branch
4 times, most recently
from
af39865 to
874a5a5
Compare
Signed-off-by: Nicol Draghici <[email protected]>
Signed-off-by: Nicol Draghici <[email protected]>
nicoldr
force-pushed
the
deprecatedModif
branch
from
ec7060f to
2d65f4d
Compare
Signed-off-by: Nicol Draghici <[email protected]>
nicoldr
force-pushed
the
deprecatedModif
branch
2 times, most recently
from
5b837e3 to
17c406e
Compare
project-zot#682 Signed-off-by: Ramkumar Chinchani <[email protected]>
nicoldr
force-pushed
the
deprecatedModif
branch
6 times, most recently
from
5d86b21 to
b046b3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nicol Draghici [email protected]
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.