Update forked repo #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amController Throw an exception in SetUpReadableByteStreamController if autoAllocateChunkSize is zero. Fixes #1089.
This throws the exception only from SetUpReadableByteStreamControllerFromUnderlyingSource, i.e. from parts of the spec reached by arbitrary web-developer provided values, instead of from SetUpReadableByteStreamController, which is deeper in. Then, we can assert that by the time the value reaches SetUpReadableByteStreamController, it's positive. This makes any other specs doing the wrong thing into assertion failures, reserving thrown exceptions for web-developer provided zeros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.