feat: high level clean code content #41
Conversation
| 3. Limit the amount of function parameters, preferably two. if you need more you can send the parameters inside an object. | ||
| 4. If you find yourself writing the same code more than once, even if its a little bit different, try to generalize it in to a function. | ||
| 5. Functions should be pure |
There was a problem hiding this comment.
[Sand]
Maybe we should add a small explanation or a reference to what pure means..
| #### React components | ||
| 1. Make your React component as short as possible | ||
| 2. Name Your Components Using Standard Naming Conventions |
There was a problem hiding this comment.
[Sand]
Whats the Standard we're using for naming conventions?
| 1. Make your React component as short as possible | ||
| 2. Name Your Components Using Standard Naming Conventions | ||
| 3. Reduce the number of props to the minimum |
There was a problem hiding this comment.
[Sand]
Should we talk about prop-types here or that's not a part of clean code?
| 4. Put Independent Functions Outside of Your Custom Hooks | ||
| 5. Split your components to container and presentational components | ||
| 6. Folderize Your Components |
There was a problem hiding this comment.
[Sand]
Maybe putting an example of this will be good :)
design/Frontend-Design.md
Outdated
| 6. Folderize Your Components | ||
|
|
||
| #### DTY |
There was a problem hiding this comment.
You have a typo here :) DTY
| #### Testing | ||
| When you write your code, you should write it in a way it would be easy to test it. make your code predictable and testable. | ||
|
|
There was a problem hiding this comment.
You can write something about TDD or BDD. It goes very well with clean code
| Interface Segregation Principle (ISP) | ||
| Dependency Inversion Principle (DIP) | ||
|
|
There was a problem hiding this comment.
You can add YAGNI as well. Uncle Bob uses it a lot
There was a problem hiding this comment.
AND I'm not sure SOLID should be here I look at it as something above clean code
| ### Clean code |
There was a problem hiding this comment.
I think we should have Do's and Don'ts on each topic.
No description provided.