Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register as config panel #848

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

jpbede
Copy link
Contributor

@jpbede jpbede commented Nov 28, 2023

Register alarmo panel as config panel like ZHA/Matter/... instead of in the sidebar. This capability was introduced mid this year (home-assistant/core#96245) in the HA core.

I don't know if we should keep the entry in the sidebar for reasons of "backwards compatibility" so as not to confuse users.

CleanShot.2023-11-28.at.14.33.57.mp4

@nielsfaber
Copy link
Owner

Hi, thanks for your contribution!
Personally (and I think this also applies to other users), I prefer to keep Alarmo in the sidebar. It's much easier and quicker to find it back.
If you could change your PR to maintain this compatibility, i'm fine with adding this.

@jpbede
Copy link
Contributor Author

jpbede commented Dec 27, 2023

Thanks, re-added the sidebar icon

@nielsfaber nielsfaber merged commit 065c7b5 into nielsfaber:main Dec 27, 2023
@jpbede jpbede deleted the panel-registration branch December 27, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants