Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: can handle check (panic) #55

Merged
merged 3 commits into from
May 18, 2024
Merged

fix: can handle check (panic) #55

merged 3 commits into from
May 18, 2024

Conversation

Crocmagnon
Copy link
Contributor

@Crocmagnon Crocmagnon commented May 14, 2024 •
edited
Loading

The current implementation returns the last handler even if it can't handle the repo, leading to a nil pointer exception.

Fixes #52

@Crocmagnon Crocmagnon requested a review from nieomylnieja as a code owner May 14, 2024 09:47
@Crocmagnon Crocmagnon changed the title fix: can handle check fix: can handle check (panic) May 14, 2024
nieomylnieja
nieomylnieja approved these changes May 18, 2024
View reviewed changes
Copy link
Owner

@nieomylnieja nieomylnieja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! Thanks for fixing this :)

@nieomylnieja nieomylnieja enabled auto-merge (squash) May 18, 2024 12:22
@nieomylnieja nieomylnieja merged commit 4d669c5 into nieomylnieja:main May 18, 2024
1 check passed
@Crocmagnon Crocmagnon deleted the fix/can-handle branch May 21, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nieomylnieja nieomylnieja nieomylnieja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when running
2 participants
@Crocmagnon @nieomylnieja