fix: remove type checking as not handling OCI type heirarchy

broadworks_ocip/base.py

@@ -81,10 +81,10 @@ def __init__(self, **kwargs):
                         raise TypeError(
                             f"{cname}: Expected {elem.name} to be a table/list but it is {type(value)}",
                         )
-                elif not isinstance(value, elem.type):
-                    raise TypeError(
-                        f"{cname}: Expected {elem.name} to be type {elem.type} but it is {type(value)}",
-                    )
+                # elif not isinstance(value, elem.type):
+                #     raise TypeError(
+                #         f"{cname}: Expected {elem.name} to be type {elem.type} but it is {type(value)}",
+                #     )
                 setattr(self, elem.name, value)
                 del kwargs[elem.name]
             elif elem.is_required:

tests/test_faulty_command.py

@@ -33,6 +33,7 @@ def test_working_base(self):
         assert cmd is not None
         assert "GroupAccessDeviceAddRequest14" in str(type(cmd))
 
+    @pytest.mark.xfail
     def test_unexpected_list(self):
         with pytest.raises(TypeError):
             api.get_command_object(
@@ -53,6 +54,7 @@ def test_unexpected_list(self):
                 ],
             )
 
+    @pytest.mark.xfail
     def test_not_a_bool(self):
         with pytest.raises(TypeError):
             api.get_command_object(
@@ -71,6 +73,7 @@ def test_not_a_bool(self):
                 ),
             )
 
+    @pytest.mark.xfail
     def test_unexpected_bool(self):
         with pytest.raises(TypeError):
             api.get_command_object(
@@ -89,6 +92,7 @@ def test_unexpected_bool(self):
                 ),
             )
 
+    @pytest.mark.xfail
     def test_too_many_things(self):
         with pytest.raises(TypeError):
             api.get_command_object(
@@ -237,3 +241,17 @@ def test_group_missing_attribute(self):
                     password="tnpass",
                 ),
             )
+
+    @pytest.mark.xfail  # we do not check for this yet
+    def test_department_key_type(self):
+        cmd = api.get_command_object(
+            "UserModifyRequest16",
+            user_id="[email protected]",
+            department=api.get_type_object(
+                "EnterpriseDepartmentKey",
+                service_provider_id="mysp",
+                name="mydept",
+            ),
+        )
+        assert cmd is not None
+        assert "UserModifyRequest16" in str(type(cmd))