Add alternative french layout #122
Conversation
The easiest way is to download Android Studio, and open it as a project in there. If you open the layout .kt file from there then it should show the code and preview in parallel, like this:
|
| @@ -954,6 +955,7 @@ enum class LetterLayerOption(override val label: String, val layout: Layout) : L | |||
| SwedishDE("Swedish (MessagEase, German-style)", SV_DE_MESSAGEASE), | |||
| Ukrainian("Ukrainian (MessagEase)", UK_MESSAGEASE), | |||
| French("French (MessagEase)", FR_MESSAGEASE), | |||
| FrenchAlt("French (Alternative)", FR_ALT), | |||
There was a problem hiding this comment.
Please try to pick a more descriptive name than "alternative". Try to capture the difference to the other french layout. As a last resort, I would go for something like "French (MessagEase, Crazy-Unicooorn)".
There was a problem hiding this comment.
That's right.
I'm considering "French (Enhanced MessagEase)" or "French (Supercharged)".
What do you think/prefer?
There was a problem hiding this comment.
I'd prefer something that doesn't make a value judgement or imply that one option is strictly superior to the other one.
There was a problem hiding this comment.
Sorry, my intention was definitely not to make a value judgement or imply that it is superior.
I was trying to convey the idea of added characters, since this is factually the case. I am sure some people would actually consider a NOT supercharged layout as a superior layout, since they would prefer less clutter.
What about "French (Enriched)" then?
Or maybe "French (Extended Character Set)" if that is not too long?
I'm afraid there is the same issue? In which case, I don't have other ideas to convey the idea of added characters, and we can just go with "French (Variant)" or "French (MessagEase, Crazy-Unicooorn)" like you suggested.
|
How about just Extended?
…On Thu, 28 Mar 2024, 15:12 Crazy Unicorn, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/src/main/java/se/nullable/flickboard/ui/Settings.kt
<#122 (comment)>:
> @@ -954,6 +955,7 @@ enum class LetterLayerOption(override val label: String, val layout: Layout) : L
SwedishDE("Swedish (MessagEase, German-style)", SV_DE_MESSAGEASE),
Ukrainian("Ukrainian (MessagEase)", UK_MESSAGEASE),
French("French (MessagEase)", FR_MESSAGEASE),
+ FrenchAlt("French (Alternative)", FR_ALT),
Sorry, my intention was definitely not to make a value judgement or imply
that it is superior.
I was trying to convey the idea of added characters, since this is
factually the case. I am sure some people would actually consider a NOT
supercharged layout as a superior layout, since they would prefer less
clutter.
What about "French (Enriched)" then?
Or maybe "French (Extended Character Set)" if that is not too long?
I'm afraid there is the same issue? In which case, I don't have other
ideas to convey the idea of added characters, and we can just go with
"French (Variant)" or "French (MessagEase, Crazy-Unicooorn)" like you
suggested.
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE6U2BVHIUJTGSMWSFDBITY2QJLBAVCNFSM6AAAAABFD5XZ7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRWGM2DINRYGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Hi, I was pointed to this work as i was somewhat dissatisfied with the old ME french layout. This seems better, but on the other, hand this seems to break some things that were fine in the ME French layout, such as the position of the l, z, à, â, etc... there are some unfortunate decisions in this design vs French ME, the 'u' was replaced by a 'l' and, while it is true that h is less common in French than it is in English, 'u' and 'l' show up roughly at the same rate, according to the corpus used by bépo. This seems to introduce discrepancies with the ME layout that make this layout harder to learn for no good reasons. One thing that is missing are the French quotes: « and » . This is also missing "œ" . What do you say we start from the good old French ME layout and we fix it? |
This fixes #76
I'm very new to PR and have never written .kt code. I also did not test my code as I didn't know how to (I just changed the code in Codespace and that's it!)
This is how the layout should look like:
Please review carefully!
And let me know if I did anything wrong, to help me improve 👍