Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

add two letters of the French alphabet that were missing from FR_PUNC_MESSAGEASE #216

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

Atn-D
Copy link
Contributor

@Atn-D Atn-D commented Aug 11, 2024

In use, I realized that they were missing, and that there were just two free spaces suitable for these characters.

@@ -19,6 +19,7 @@ val FR_PUNC_MESSAGEASE_MAIN_LAYER = Layer(
Direction.TOP_RIGHT to Action.Text("à"),
Direction.BOTTOM_RIGHT to Action.Text("v"),
Direction.LEFT to Action.Text("«"),
Direction.TOP_LEFT to Action.Text("æ"),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer leaving a-topleft free for eventually implementing #72 :/

Maybe there's something else it could be squeezed in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On MessagEase, it's precisely this © key that transforms O and Œ and A into Æ!

Issue #72 could therefore solve my problem, is it possible to pay attention that the Æ and Œ are well implemented please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long do you think it will take to implement ©?
If that's a long time, what do you think if we validate my changes temporarily, and the day the © is implemented, we remove these two characters?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Æ is actually already implemented via Zalgo mode: a, enter-down, e. Admittedly not super convenient though.

Oe isn't currently registered there, but should be easy enough to add.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nightkr Thanks for the discovery!
There should be a pictogram on the enter-down, I didn't know it existed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to hear if you have any suggestion!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nightkr added a commit that referenced this pull request Aug 29, 2024
nightkr added a commit that referenced this pull request Aug 29, 2024
@nightkr nightkr merged commit d63c0d9 into nightkr:main Sep 29, 2024
@nightkr
Copy link
Owner

nightkr commented Sep 29, 2024

On second thought, I think this is fine to merge. Zalgo mode kind of supersedes the need for the ME-style combiner anyway (and, worst case, it's probably fine to let the specific layout override it if necessary).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants