Restore identifier #164
Merged
Restore identifier #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a few lines from commit 08e6a80.
Merged
|
Repeating comment in both PR #163 and PR #164 because both are required. Success for Browser Build with PR 163 + 164 added to dev (including the merged PR 165).
First build failed because I inadvertently modified swiftpm/Package.resolved |
marionbarker
approved these changes
May 9, 2024
bjornoleh
approved these changes
May 9, 2024
|
Strange to I understand the difference 😫 |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a few lines from commit 08e6a80.
@avouspierre mentioned it wasn't used now, so it was okay to delete, and it built and worked fine with an Xcode build, but it prevented me from building via GitHub: failed run
After applying this PR, it built successfully: successful run