-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temp target duration fix #95
Conversation
applied a new time formatter for notification display restructured some sentences for display fix general spelling and grammar
Suggestion: We could make the function public, move it to a utility function and apply it in places where "min" or similar is hard coded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the changes, and see the need for updating the strings related to enacting Temp targets by iOS Shortcuts. This looks good to me. Did not build to test.
ALso the Open-iAPS strings seem to be correctly changed here.
I have no experience with iOS shortcuts, so I‘ll omit doing a review. Your changes look reasonable and limited, so sensible. |
Thanks! Please remember to create the PR to dev as well when this is tested in alpha, as we do not plan on merging alpha into dev. |
Fix unit conversion and min/max checks for mmol/L glucose values
FIxed the temp target duration to be more dynamic when passing any number not null.
Refactored messages to be more consistent when addressing user for temp targets.
Renamed references to "Temp Target" to be more consistent from "Temp Preset"
fixed OiAPS references in a few classes to Open-iAPS
Steps to reproduce:
Evidence of fix: