Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp target duration fix #95

Merged
merged 7 commits into from
Apr 14, 2024
Merged

Temp target duration fix #95

merged 7 commits into from
Apr 14, 2024

Conversation

kylmcw
Copy link
Contributor

@kylmcw kylmcw commented Apr 13, 2024

FIxed the temp target duration to be more dynamic when passing any number not null.
Refactored messages to be more consistent when addressing user for temp targets.
Renamed references to "Temp Target" to be more consistent from "Temp Preset"
fixed OiAPS references in a few classes to Open-iAPS

Steps to reproduce:

  • Create and set temp target as preset
  • Run temp target from pre programmed shortcut in Shortcuts

Evidence of fix:
Target 'Temp Test' applied for 2hrs
Target 'Minutes test' applied for 5min
Target 'Odd minutes' applied for
Confirm to apply temporary target

kylmcw added 6 commits April 13, 2024 09:43
@kylmcw kylmcw requested a review from Sjoerd-Bo3 April 13, 2024 09:21
@kylmcw
Copy link
Contributor Author

kylmcw commented Apr 13, 2024

Suggestion: We could make the function public, move it to a utility function and apply it in places where "min" or similar is hard coded

Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the changes, and see the need for updating the strings related to enacting Temp targets by iOS Shortcuts. This looks good to me. Did not build to test.

ALso the Open-iAPS strings seem to be correctly changed here.

@dnzxy
Copy link
Contributor

dnzxy commented Apr 13, 2024

I have no experience with iOS shortcuts, so I‘ll omit doing a review. Your changes look reasonable and limited, so sensible.

@kylmcw kylmcw merged commit 2656373 into nightscout:alpha Apr 14, 2024
@bjornoleh
Copy link
Contributor

Thanks! Please remember to create the PR to dev as well when this is tested in alpha, as we do not plan on merging alpha into dev.

@MikePlante1 MikePlante1 mentioned this pull request Apr 16, 2024
@MikePlante1 MikePlante1 mentioned this pull request May 3, 2024
Sjoerd-Bo3 pushed a commit to Sjoerd-Bo3/Trio that referenced this pull request Nov 1, 2024
Fix unit conversion and min/max checks for mmol/L glucose values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants