Enhancement - Design Input

[gregwaehner]

Hey all - now that I've resolved my "vanishing arrows" due to my dexcom-uploader... I saw a notification come in tonight re: client.js and BG thresholds. (https://github.com/aaronjknox/cgm-remote-monitor)

I'm happy to attack this one, but would like group perspective -- to me, the BG high and low is a threshold that will be highly varied by person and style. So, to me, that is a prime candidate for an environment variable / configuration file.

What I would really like to do is rename the "database_configuration.json" to "application_variables.json" and make it a generic properties file... and then put the BG High and Low in there... a single parameter file, all loaded via server.js.

If the group doesn't like that, then Plan B would be a "bg_threshold_configuration.json" file that would contain BG High and Low values... again, loaded by server. js.

I'm a node.js rookie, so I'm assuming that I can load variables into "session namespace" via server.js and have them available to client.js... but if not, then I'd have to put the require statement in client.js.

Thoughts before I branch off and do it?

• Greg

[bewest]

Sounds good. I prefer environment variables for config options like this, but a config.json would be fine as well. We should probably make a /config endpoint so that the webpage and client.js can fetch settings from the server.

[jasoncalabrese]

I'd like to see in app settings for things like this, or even a separate page to start with. The values could be persisted to mongo. Once we have a generic settings system it will enable lots of other features and experimentation.

[bewest]

That's true, simple config file/environment variables to might help us model what kind of settings to track in mongo ans simplify hacking in the short term. A simple settings page can and should display all the current settings, and then when we're happy we can make it write settings to mongo/config file.

[brianhanifin]

Sorry if I am being overzealous by closing this, the amount of open issues is messing with my "ADD". ;) You are welcome to reopen it if you like.