Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade minimed-connect-to-nightscout to fix GuardianConnect for US servers (and update npm dependencies) #4915

Merged
merged 4 commits into from
Aug 24, 2019
Merged

upgrade minimed-connect-to-nightscout to fix GuardianConnect for US servers (and update npm dependencies) #4915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a383ff
upgrade minimed-connect-to-nightscout to 1.30to fix GuardianConnect …
Aug 22, 2019
86844d4
npm update to fix security issue
Aug 22, 2019
06babf9
update to minimed-connect-to-nightscout 1.3.1
PieterGit Aug 23, 2019
c24780f
fix typo and make more clear we don't release with insecure dependencies
PieterGit Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Nightscout is a Node.js application. The basic installation of the software for

We develop on the `dev` branch. All new pull requests should be targeted to `dev`. The `master` branch is only used for distributing the latest version of the tested sources.

You can get the dev branch checked out using `git checkout dev`.
You can get the `dev` branch checked out using `git checkout dev`.

Once checked out, install the dependencies using `npm install`, then copy the included `my.env.template`file to `my.env` and edit the file to include your settings (like the Mongo URL). Leave the `NODE_ENV=development` line intact. Once set, run the site using `npm run dev`. This will start Nigthscout in the development mode, with different code packaging rules and automatic restarting of the server using nodemon, when you save changed files on disk. The client also hot-reloads new code in, but it's recommended to reload the the website after changes due to the way the plugin sandbox works.

Expand Down Expand Up @@ -119,8 +119,9 @@ We assume all new Pull Requests are at least smoke tested by the author and all
Please include a description of what the features do and rationalize why the changes are needed.

If you add any new NPM module dependencies, you have to rationalize why there are needed - we prefer pull requests that reduce dependencies, not add them.
Before releasing a a new version, we check with `npm audit` if our dependencies don't have known security issues.

When adding new features that add confugration options, please ensure the `README` document is amended with information on the new configuration.
When adding new features that add configuration options, please ensure the `README` document is amended with information on the new configuration.

## Bug fixing

Expand Down
Loading