Release 14.0.7 #6445

sulkaharo · 2020-11-11T17:25:40Z

Test if database is in read only mode when Nightscout starts and give an error if read only mode is detected
The client now checks if the server has loaded the initial data and is ready to server the client before letting user into the main UI
Google Home and Amazon Alexa fixes - users who use either probably should update their Nightscout
Fixed Pushover crashing Nightscout if Pushover servers are returning an internal server error
Fix swagger for APIv3
Language updates
Use the delta plugin data to show the delta in the clock views
Update Node version checks during startup to refer to Node 10 and 12 & allow any LTS version
Fix disabling the BG alarms for simple alarms
Load battery and other rare events up to two months back
Possibly fixes compatibility with ios9 - needs testing
Unified black and color clock layouts
Update clock data every 20 seconds
Update clock time every second
Fix how CSP policy is set for Helmet, fixes App crashed on heroku after deplay new build 14.0.6 #6260
Authorization fix for misformatted URLs
Added unit test for batch upload of CGM entries
Improved / removed some logging

* Add onerror handler for pushover

* APIv3: isolating documents from tests (not allowing clashes of calculated identifiers) * removing unused async keyword * fixing api v3 swagger and moving it to /api3-docs Co-authored-by: Petr Ondrusek <[email protected]> Co-authored-by: Petr Ondrůšek <[email protected]>

* Fixed #5632 - Improved value resolution * More value resolution improvements * Fixed a couple object paths

* Corrected db size config for virtual assistants * Language fix, improvements, added dbsize to virtAsst config * Using env * Added logging * Debug logging * Different logging * More troubleshooting * Another try * Reverted stuff, added dbsize to server defaults * Fixed test * Fixed another test

* Use the delta plugin data to show the delta in the clock views * Update Node checks * Fix disabling the BG alarms for simple alarms * Load battery and other rare events up to two months back * Possibly fixes compatibility with ios9 - needs testing * Unified black and color clock layouts * Update clock data every 20 seconds * Update clock time every second * Fix how CSP policy is set for Helmet, fixes #6260 * Authorization fix for misformatted URLs * Added unit test for batch upload of CGM entries * Improved / removed some logging * Test if user is in read only mode when Nightscout starts and give an error if so

* Finished first round of translation for Hungarian language * Added hungarian language to the readme file * Fixes * WIP * Typo fixes and changes to translations * Update language.js Fixed some mistyped language keys Co-authored-by: Andy Feher <[email protected]> Co-authored-by: Sulka Haro <[email protected]>

Isfjell -> Istapp Co-authored-by: Sulka Haro <[email protected]>

Co-authored-by: Sulka Haro <[email protected]>

…6457)

inventor96 · 2020-11-14T06:04:43Z

Not sure if it's an issue or not, but when I first navigated to my site after deploying the updated dev branch, I got the following message: Redirecting you to the Profile Editor to create a new profile. It looks like it was a JS alert() call, not an HTML modal or anything. I copied the text to write this post, then when I went back, the message was gone and the profile editor was loaded. It said I was still admin authorized, and all the values looked normal to me. I didn't do anything with the page, and just clicked again on the link to my site on my bookmarks bar in the browser. Everything appeared to load up just fine.

I have a second NS site pointed at the same Mongo DB (config issue between OpenAPS and xDrip+, so that's my workaround). When I load it, I did not get the same message. It did an initial load, then one reload, and then everything was just fine. So probably a one-off deal, but figured I'd report it, just in case.

sulkaharo · 2020-11-14T07:31:54Z

@inventor96 Right - this seems to be a timing issue, where if you load the site before the backend has got the full dataset loaded, it'll show the dialog. I'll check if there's a simple workaround to enable the site to not load the UI before the backend is hot.

…the server has loaded initial data from Mongo before the user is directed to the UI

sulkaharo · 2020-11-14T09:14:23Z

Ok I added a new feature, where the client now checks if the server is ready to actually serve the client - if the server is still in process of booting up and loading data from Mongo, the client waits until the load is complete.

* Changed report BG target to allow fractional numbers

unsoluble · 2020-11-30T03:08:52Z

lib/client/clock-client.js

@@ -150,7 +122,7 @@ client.render = function render (xhr) {
    let bgTargetBottom = client.settings.thresholds.bgTargetBottom;
    let bgTargetTop = client.settings.thresholds.bgTargetTop;

-    let bgNum = parseFloat(rec.sgv);
+    let bgNum = parseFloat(rec.mgdl);


Why was this changed? It breaks for anyone using mmol/L in their core settings.

The BG targets are converted to mgdl for all users for Nightscout's logic. If you check what the target values this gets compared to, the values are in mgdl even for mmol users. Have you observed issues or did you comment this just from reading code?

It's hard to trace the logic here, but yes, something in this commit is a breaking change when your thresholds are set in mmol. Previously the clock colours were correct, now they are not. If I change all my thresholds in Config Vars to mg/dl equivalents, the colours are correct again.

Actually, it appears to be more complex than that — with my thresholds as mg/dl values, the colours were correct within a certain range (when the kid was lower), but now that he's past BG_TARGET_TOP it's not rendering the correct colour no matter which units I use. But it's correct in the main display:

Right, I found a bug in the init order of the clock client (which has been there for a long time), so looks like the clock has been using the target defaults instead of the configured targets for some time now. Fixing. (The changes to the clock were made to have the clock use the same math as the rest of Nightscout, so things like the shown BG delta would match the rest of the system - with the custom delta calculation in the clocks, the shown values were almost but not the same.)

Gotcha. I was a few versions back before today, missed when that change happened I suppose. Thanks for finding the fix. :)

sulkaharo and others added 11 commits September 30, 2020 09:14

* Bump version to 14.0.7

f08f9ea

* Add onerror handler for pushover

Fixed #5852 - Updated Google Home setup steps (#6195)

b6bde83

Use lodash.get() in virtual assistant API endpoints (v2) (#6199)

76b9de9

* Fixed #5632 - Improved value resolution * More value resolution improvements * Fixed a couple object paths

Update language.js (#6193)

6a84be1

Isfjell -> Istapp Co-authored-by: Sulka Haro <[email protected]>

#5991 Typo in translation (#6217)

60424d3

Co-authored-by: Sulka Haro <[email protected]>

add missing translations (#6346)

92ac596

Co-authored-by: Sulka Haro <[email protected]>

Updated Alexa's intents because Amazon required new ones yet again. (#…

ead1370

…6457)

sulkaharo added 2 commits November 14, 2020 11:05

Add runtime state tracking to Nightscout, where client now checks if …

376c790

…the server has loaded initial data from Mongo before the user is directed to the UI

Add file missing from previous commit

978f205

sulkaharo added 6 commits November 14, 2020 11:36

Merge branch 'master' into dev

85c59a6

Fix unit tests

384de77

Merge branch 'master' into dev

edf432a

Fix the read detection to work correctly with MongoDB Atlas

d7f472a

* Added basal and careportal to default plugins

a9692d1

* Changed report BG target to allow fractional numbers

Increase load interval to 5 seconds

e7d080a

sulkaharo merged commit 257dfb2 into master Nov 15, 2020

unsoluble reviewed Nov 30, 2020

View reviewed changes

robster7674 mentioned this pull request Mar 13, 2023

BG Delta in Clock Views #7952

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 14.0.7 #6445

Release 14.0.7 #6445

sulkaharo commented Nov 11, 2020 •

edited

Loading

inventor96 commented Nov 14, 2020

sulkaharo commented Nov 14, 2020

sulkaharo commented Nov 14, 2020

unsoluble Nov 30, 2020

sulkaharo Nov 30, 2020

unsoluble Nov 30, 2020

unsoluble Nov 30, 2020

sulkaharo Nov 30, 2020

unsoluble Nov 30, 2020

Release 14.0.7 #6445

Release 14.0.7 #6445

Conversation

sulkaharo commented Nov 11, 2020 • edited Loading

inventor96 commented Nov 14, 2020

sulkaharo commented Nov 14, 2020

sulkaharo commented Nov 14, 2020

unsoluble Nov 30, 2020

Choose a reason for hiding this comment

sulkaharo Nov 30, 2020

Choose a reason for hiding this comment

unsoluble Nov 30, 2020

Choose a reason for hiding this comment

unsoluble Nov 30, 2020

Choose a reason for hiding this comment

sulkaharo Nov 30, 2020

Choose a reason for hiding this comment

unsoluble Nov 30, 2020

Choose a reason for hiding this comment

sulkaharo commented Nov 11, 2020 •

edited

Loading