Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release share2nightscout-bridge 0.2.0 #34

Merged
merged 31 commits into from
Jan 4, 2019
Merged

Release share2nightscout-bridge 0.2.0 #34

merged 31 commits into from
Jan 4, 2019

Conversation

PieterGit
Copy link
Collaborator

@PieterGit PieterGit commented Jan 2, 2019

Changes:

@PieterGit PieterGit added this to the 0.2.0 milestone Jan 2, 2019
@PieterGit
Copy link
Collaborator Author

PieterGit commented Jan 2, 2019

@scottleibrand @bewest @veryfancy @ruuddotorg @mayaalinder @kenstack @unsoluble @sulkaharo
(and all other share2nightscout bridge users)

Can you review these changes? I'm about to do a npm release of this share2nightscout version and integrate it into Nightscout, so we can release it with Nightscout 0.11 release.

If anybody wants to take ownership of this project please do. I will do the 0.2.0 release, because I want to get rid of the branched version within Nightscout and want to use npm packages as Nightscout dependencies. I'm not a share2nightscout bridge user, so I need your help to test it and approve it.

If nobody wants to take ownership now then please append your names a potential developer or tester for share2nightscout bridge plugin with a PR to https://github.com/nightscout/cgm-remote-monitor/blob/dev/CONTRIBUTING.md#plugin-contributors

In a future Nightscout release I would only like to ship maintained plugins with Nightscout, so please step up. There has not been much activity in this GitHub lately, so maintaining this plugin should not be a lot of work.

@PieterGit
Copy link
Collaborator Author

Please test nightscout/cgm-remote-monitor#4175

Copy link
Member

@sulkaharo sulkaharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the caveat that I can't currently test this

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@PieterGit
Copy link
Collaborator Author

@PieterGit PieterGit merged commit cb558a3 into master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants