Fixed handling ECONNRESET errors (fixes #1936)

[marian-r]

• fixed handling of session creation errors during test case run to be reported as test errors
• fixed retries for session creation - errors are now reported only after retry limit is reached
• covered with test

[drabelo]

Whats up with this pull request? I really need this fix

[marian-r]

@beatfactor by any chance, would you be able to look at this PR? It is fixing a long-lasting issue and it is covered with tests.

[beatfactor]

@marian-r yes, the issue will be addressed in the next release, but in a slightly different manner, so I'm not sure yet if the PR will still be needed. But we'll see once the new version is out, which should be this week.

[marian-r]

@beatfactor cool, would you be able to share more details (commit, PR, ...) so I could take a look? We are currently using my fork and the ECONNRESET errors are gone.

[beatfactor]

Your PR covers these ECONNRESET errors only for the session create command, but they could arise for any type of requests, so I covered those as well (like api commands). I will push the master but the npm publish needs to wait until the docs update is done.

[VikasGhorpade]

@beatfactor When can we expect this PR to be merged and published?

[npapagna]

Hi! Any plans to integrate this fix in the short term? Thanks!

[marian-r]

The maintainer of this project decided not to accept this PR and implement the fix in a different way. I am not sure what is the state of that work, but if you urgently need the fix you can replace Nightwatch version in your package.json with my branch marian-r/nightwatch#issue/1936-session-econnreset-fix. That's what I've been doing and it makes ECONNRESET errors to go away.

[beatfactor]

@VikasGhorpade @npapagna @marian-r The fix is already implemented. As I mentioned earlier, this PR only addresses the errors from the session create command, but this kind of errors could arise from other commands as well, so I didn't feel this fix was completely adequate.

However, for the retries to work you first need to set timeout_options accordingly, it isn't enabled by default.

E.g.:

timeout_options: {
  {
    timeout: 15000, 
    retry_attempts: 3
  }
}

More info

We can of course look at this again if you are still seeing issues.