Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork, Commit, Merge - Hard Issue (HTML/CSS/JavaScript) #1164

Closed
nikohoffren opened this issue Oct 23, 2023 · 4 comments
Closed

Fork, Commit, Merge - Hard Issue (HTML/CSS/JavaScript) #1164

nikohoffren opened this issue Oct 23, 2023 · 4 comments

Comments

@nikohoffren
Copy link
Member

Fork, Commit, Merge - Hard Issue (HTML/CSS/JavaScript)

Create a Functional Clock using HTML, CSS and JavaScript

Note: You don't have ask permission to start solving the issue or get assigned, since these issues are supposed to be always open for new contributors. The actions-user bot will reset the file back to previous state for the next contributor after your commit is merged. So you can just simply start working with the issue right away!

Issue created by krishvsoni.

How to Get Started:

Open the tasks/html/hard/clock directory from the root of your project.
Then open the index.html, index.js and style.css files and start implementing your solution!

Objective:

In this task you have to implement clock functionality for HTML/CSS/JavaScript clock project.
The project is missing the implementation of clock functionality. This involves creating clock hands, numbers, and making sure they function in real-time.

Files:

  • tasks/html/hard/clock/index.html
  • tasks/html/hard/clock/index.js
  • tasks/html/hard/clock/style.css

Tasks:

HTML (index.html)

  • Add code for clock hands (Hour, Minute, and Second hands) using div elements with appropriate class names and data attributes.

CSS (style.css)

  • Define styles for the minute and hour hands to distinguish them from the second hand.
  • Define rotations for the clock numbers (1 to 12).

JavaScript (index.js)

  • Implement setRotation function to update the rotation of a DOM element based on the provided rotationRatio.
  • Calculate the current time and update the clock hands' positions based on that.
  • Call the setClock function to initialize the clock's position when the page loads.

Notes:

  • Please follow code style guides and best practices for HTML, CSS, and JavaScript.
  • Make sure to test your changes locally before submitting a pull request.

If you are using VS Code and have for example Live Server extension, you can simply open index.html with the server and check how the clock looks. If the clock looks to work as expected, you are ready to make a pull request!
If you do not have Live Server extension, you'll find information about installing and how to use it here.


Check out README.md for more instructions and how to make a pull request.

Feel free to ask any questions here if you have some problems!

Also, kindly give this project a star to enhance its visibility for new developers!

@JatinPhogat
Copy link
Contributor

Hi @nikohoffren Thanks for creating this issue . I am currently working on it and would creating a pr once completed

@nikohoffren
Copy link
Member Author

Hi @nikohoffren Thanks for creating this issue . I am currently working on it and would creating a pr once completed

Sure, sounds good!

@JatinPhogat
Copy link
Contributor

Thanks for the acknowledgement , @nikohoffren I have completed the tasks , tested the clock and opened a pull request . I request you to please check it . Thank you

@nikohoffren nikohoffren reopened this Oct 26, 2023
nikohoffren added a commit that referenced this issue Oct 26, 2023
Fork, Commit, Merge - Hard Issue (HTML/CSS/JavaScript) #1164
@chinmay7016
Copy link

@nikohoffren pls review it and merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants