-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service): Add Viber #415
Conversation
Codecov ReportBase: 72.18% // Head: 72.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 72.18% 72.48% +0.30%
==========================================
Files 30 32 +2
Lines 924 985 +61
==========================================
+ Hits 667 714 +47
- Misses 197 203 +6
- Partials 60 68 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hey @svaloumas thanks for your time on reviewing this. I've addressed your comments, please help to re-review it again, thank you! also @nikoksr would appreciate if you have any comment on this PR. Thank you! |
@irfansofyana I appreciate your hustle. I firmly believe @svaloumas reviews are of a consistent high quality. There won't be additional value my review could provide. |
@nikoksr gotcha, thank you! |
@irfansofyana Apologies for getting back late to this! Let's just remove this sneaky line here that causes the linter failure and we're ready to go! 👍 |
@svaloumas upss sorry for that, it should be fixed now. Thanks! |
Description
Implement Viber service to solve #114
Motivation and Context
How Has This Been Tested?
Unit Test
End-to-end testing
Screenshots / Output (if appropriate):
Screenshot End to end testing
The script that is used can be seen in the README with some modifications to change dummy values.
Unit Test
All Test Results
There is a failure in
syslog
service but it's not related with this PR, maybe we can solve it in different PR?Types of changes
Checklist: