Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace dghubble/go-twitter with drswork/go-twitter active fork #468

Merged

Conversation

svaloumas
Copy link
Collaborator

Description

The dghubble/go-twtitter pkg is now deprecated and we need to replace it with an active fork of the repository.

Motivation and Context

As dghubble/go-twitter has been archived and is no longer maintained, we need to replace it with an active fork of the package. Currently, drswork/go-twitter seems to be the best candidate for us to avoid introducing backward compatibility issues.

How Has This Been Tested?

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other - Dependency replacement (non-breaking change)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Base: 72.48% // Head: 72.48% // No change to project coverage 👍

Coverage data is based on head (820770d) compared to base (8e5230b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   72.48%   72.48%           
=======================================
  Files          32       32           
  Lines         985      985           
=======================================
  Hits          714      714           
  Misses        203      203           
  Partials       68       68           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@svaloumas svaloumas requested a review from nikoksr November 17, 2022 12:31
@nikoksr nikoksr merged commit d9d4463 into nikoksr:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants