Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): Zulip Service integration #711

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d345625
feat: zulip client to send messages via bot email and bot api key
saisumith770 Oct 3, 2023
1139977
fix: validations for topic and content
saisumith770 Oct 3, 2023
47c8d53
refactor: extracted all errors into errors.go
saisumith770 Oct 3, 2023
df62055
test(message): added tests for message validation
saisumith770 Oct 3, 2023
5abae06
doc(validation): added comments for the validations
saisumith770 Oct 3, 2023
6f44263
feat(hooks): hooks for configuring the client
saisumith770 Oct 3, 2023
3527f9c
test(hooks): added tests for all hooks
saisumith770 Oct 3, 2023
2f2b9dd
Merge branch 'nikoksr:main' into zulip-integration
saisumith770 Oct 3, 2023
4620583
refactor(test): cleaned up the assert messages
saisumith770 Oct 3, 2023
3fbaa9c
ci: nits
saisumith770 Oct 3, 2023
4797ca3
test(client): added tests for all client methods
saisumith770 Oct 3, 2023
df8b1bb
Merge branch 'zulip-integration' of https://github.com/saisumith770/n…
saisumith770 Oct 3, 2023
9fcff13
ci: fix linting issue
saisumith770 Oct 3, 2023
34003d1
test: changed assert to require as per repo testing rules
saisumith770 Oct 3, 2023
a0c958e
feat(service): added wrapper for zulip client
saisumith770 Oct 5, 2023
3e3e738
test(service): testing zulip wrapper
saisumith770 Oct 5, 2023
45d3cf5
ci: linting nits
saisumith770 Oct 5, 2023
68c236a
doc: added docs as per repo style
saisumith770 Oct 5, 2023
fba8d3b
doc: updated README
saisumith770 Oct 5, 2023
35292f0
Merge branch 'main' into zulip-integration
saisumith770 Oct 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci: linting nits
  • Loading branch information
saisumith770 committed Oct 5, 2023
commit 45d3cf5ee6d01d60ad0d1a091c0441c77e2c6c3f
3 changes: 2 additions & 1 deletion service/zulip/mock_zulip_client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion service/zulip/zulip_test.go
Original file line number Diff line number Diff line change
@@ -4,8 +4,9 @@ import (
"context"
"testing"

z "github.com/nikoksr/notify/service/zulip/client"
"github.com/stretchr/testify/require"

z "github.com/nikoksr/notify/service/zulip/client"
)

func TestZulip_New(t *testing.T) {