[MAINT] Fix failing tests on main due to creating unsupported GiftiDataArrays #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
This was referenced Apr 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #3649 +/- ##
==========================================
- Coverage 91.43% 91.35% -0.09%
==========================================
Files 133 133
Lines 15471 15470 -1
Branches 3207 3207
==========================================
- Hits 14146 14132 -14
- Misses 780 793 +13
Partials 545 545 see 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2 tasks
Remi-Gau
approved these changes
Apr 4, 2023
bthirion
approved these changes
Apr 4, 2023
5 tasks
|
Will go ahead and merge this one. |
Remi-Gau
pushed a commit
to Remi-Gau/nilearn
that referenced
this pull request
Apr 5, 2023
…taArrays (nilearn#3649) * Set Gifti valid datatype * Fix remaining tests
musicinmybrain
added a commit
to musicinmybrain/nipy
that referenced
this pull request
Sep 21, 2023
musicinmybrain
added a commit
to musicinmybrain/nipy
that referenced
this pull request
Sep 21, 2023
matthew-brett
added a commit
to nipy/nipy
that referenced
this pull request
Sep 21, 2023
MRG: Fix test creating unsupported double-precision GiftiDataArray See: nipy/nibabel#1198 nipy/nibabel#1199 nilearn/nilearn#3649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See failures on main, e.g. https://github.com/nilearn/nilearn/actions/runs/4605300937/jobs/8137164142
Nibabel release includes a fix for enforcing valid datatypes for GIFTI
See nipy/nibabel#1199