Better handling for session expiry (deephaven#2986)

Server should send a non-empty message when the session ends, and js client should notify user of failure in all cases. Partial deephaven#2985
niloc132 · Oct 11, 2022 · e582a42 · e582a42
1 parent 7d6b4ff
commit e582a42
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/server/src/main/java/io/deephaven/server/session/SessionService.java b/server/src/main/java/io/deephaven/server/session/SessionService.java
@@ -5,6 +5,7 @@
 
 import com.github.f4b6a3.uuid.UuidCreator;
 import com.google.protobuf.ByteString;
+import com.google.rpc.Code;
 import io.deephaven.auth.AuthenticationException;
 import io.deephaven.auth.AuthenticationRequestHandler;
 import io.deephaven.configuration.Configuration;
@@ -383,6 +384,9 @@ public TerminationNotificationListener(
 
         @Override
         void onClose() {
+            GrpcUtil.safelyExecuteLocked(responseObserver, () -> {
+                responseObserver.onError(GrpcUtil.statusRuntimeException(Code.UNAUTHENTICATED, "Session has ended"));
+            });
             terminationListeners.remove(this);
         }
 

diff --git a/web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java b/web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java
@@ -438,8 +438,11 @@ private void subscribeToTerminationNotification() {
                             // restart the termination notification
                             subscribeToTerminationNotification();
                             return;
+                        } else {
+                            info.notifyConnectionError(Js.cast(fail));
                         }
                     }
+                    assert success != null;
 
                     // welp; the server is gone -- let everyone know
                     info.notifyConnectionError(new ResponseStreamWrapper.Status() {