add interval_type to isochrone objects #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
commented
Jul 11, 2022
| @@ -429,7 +429,7 @@ def isochrones( | |||
| intervals, | |||
| type="json", | |||
| buckets=1, | |||
| interval_type=None, | |||
There was a problem hiding this comment.
we'll default explicitly to time for all providers now, otherwise it could be None
chrstnbwnkl
approved these changes
Jul 12, 2022
routingpy/expansion.py
Outdated
| @property | ||
| def interval_type(self): | ||
| """ | ||
| Was is based on 'distance' or 'time'? |
There was a problem hiding this comment.
Suggested change
| Was is based on 'distance' or 'time'? | |
| Was it based on 'distance' or 'time'? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the network analyst it's easier if we store the
interval_type/metricin theIsochroneandExpansionsobjects so we don't have to pass that stuff around needlessly.PR is based on #71
also did a round of dependency updates.