Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc2 outputs in current work dir #6583

Closed
dom96 opened this issue Oct 24, 2017 · 3 comments · Fixed by #14324
Closed

doc2 outputs in current work dir #6583

dom96 opened this issue Oct 24, 2017 · 3 comments · Fixed by #14324
Labels
Documentation Content Related to documentation content (not generation). Path Handling Tools

Comments

@dom96
Copy link
Contributor

dom96 commented Oct 24, 2017

This isn't consistent with the way output binaries are generated. (This is possibly a duplicate).
@dom96 dom96 added Documentation Content Related to documentation content (not generation). Tools labels Oct 24, 2017
@FedericoCeratto
Copy link
Member

Confusingly, "nim doc" behaves like "nim c".

@narimiran
Copy link
Member

Tested with v0.19.0:

Both nim doc and nim doc2 create outputs in the subdirectory. E.g. nim doc lib/pure/collections/sequtils.nim produces ./lib/pure/collections/sequtils.html.

@timotheecour
Copy link
Member

timotheecour commented May 8, 2020 •
edited
Loading

this should be re-opened; a regression happened since 0.19.0 and it outputs again in $pwd.
see getOutFile (result = conf.outDir / changeFileExt(filename, ext) which resolves to $pwd/changeFileExt(filename, ext) when conf.outDir is empty)

the bug is that "" / path resolves to path instead of giving an error

This was referenced May 8, 2020
Open
Merged
Open
@dom96 dom96 reopened this May 9, 2020
@timotheecour timotheecour mentioned this issue May 10, 2020
Merged
timotheecour added a commit to timotheecour/Nim that referenced this issue May 12, 2020
@timotheecour
fix nim-lang#6583 nim doc now outputs again in $projdir, like the oth…
3cb2d55 
…er commands
@timotheecour timotheecour mentioned this issue May 12, 2020
Merged
5 tasks
timotheecour added a commit to timotheecour/Nim that referenced this issue May 12, 2020
@timotheecour
fix nim-lang#6583 nim doc now outputs again in $projdir, like the oth…
a1491ef 
…er commands
timotheecour added a commit to timotheecour/Nim that referenced this issue May 13, 2020
@timotheecour
fix nim-lang#6583 nim doc now outputs again in $projdir, like the oth…
741f71d 
…er commands
timotheecour added a commit to timotheecour/Nim that referenced this issue May 13, 2020
@timotheecour
fix nim-lang#6583 nim doc now outputs again in $projdir, like the oth…
5f3f356 
…er commands
@timotheecour timotheecour mentioned this issue May 18, 2020
Closed
timotheecour added a commit to timotheecour/Nim that referenced this issue May 20, 2020
@timotheecour
fix nim-lang#6583 nim doc now outputs again in $projdir, like the oth…
29eff42 
…er commands
timotheecour added a commit to timotheecour/Nim that referenced this issue May 20, 2020
@timotheecour
refs nim-lang#6583 fix nim doc output
b7d777c
timotheecour added a commit to timotheecour/Nim that referenced this issue May 21, 2020
@timotheecour
refs nim-lang#6583 fix nim doc output
a77bffc
timotheecour added a commit to timotheecour/Nim that referenced this issue May 21, 2020
@timotheecour
refs nim-lang#6583 fix nim doc output
7a6c715
timotheecour added a commit to timotheecour/Nim that referenced this issue May 23, 2020
@timotheecour
refs nim-lang#6583 fix nim doc output
20cba5e
timotheecour added a commit to timotheecour/Nim that referenced this issue May 23, 2020
@timotheecour
refs nim-lang#6583 fix nim doc output
2c881ac
Araq pushed a commit that referenced this issue May 25, 2020
@timotheecour
fix #6583, fix #14376, index+search now generated for all projects, m…
5828254 
…any bug fixes with nim doc (#14324)

* refs #6583 fix nim doc output
* changelog
* change default for outDir when unspecified
* cleanups
* --project implies --index
EchoPouet pushed a commit to EchoPouet/Nim that referenced this issue Jun 13, 2020
@timotheecour @EchoPouet
fix nim-lang#6583, fix nim-lang#14376, index+search now generated for…
71734a9 
… all projects, many bug fixes with nim doc (nim-lang#14324)

* refs nim-lang#6583 fix nim doc output
* changelog
* change default for outDir when unspecified
* cleanups
* --project implies --index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Content Related to documentation content (not generation). Path Handling Tools
Projects
None yet
Milestone
No milestone
4 participants
@FedericoCeratto @dom96 @timotheecour @narimiran