On windows, os.relativePath returns path as is when roots are different #12329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before making this PR,
os.relativePath
returns wrong path when a root ofpath
and a root ofbase
are different.output:
This PR uses
PathIsSameRootW
orPathIsSameRootA
windows API to compare roots of input paths.If they were not same root, returns
path
as is.But
PathIsSameRootW
orPathIsSameRootA
seems don't support DOS device paths.This code test
PathIsSameRootW
.https://gist.github.com/demotomohiro/81702d8a0bf951d6a46b9954093d69bb
APIs in pathcch.h header supports DOS device paths but there is not API to compare root of paths and they are only available on windows 8 or newer.
Implementing
PathIsSameRoot
that supports DOS device paths can be larger code than this PR.