Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[superseded] new quoted: outplace version of addQuoted #13301

Closed
wants to merge 2 commits into from

Conversation

timotheecour
Copy link
Member

quoted is what's most convenient to use most of the time (addQuoted when efficiency is needed); I'm putting it in system (yes, more bloat) because addQuoted is already there

The alternative I considered was to put it under strutils but this seemed worse: strutils carries a bunch of dependencies, and it'd be awkward to split quoted(outplace) vs addQuoted(inplace) in different modules

@timotheecour timotheecour changed the title new system.quoted: outplace version of addQuoted new quoted: outplace version of addQuoted Jan 31, 2020
@Araq
Copy link
Member

Araq commented Jan 31, 2020

Not acceptable. I never need it, so why add it to system?

@timotheecour
Copy link
Member Author

PTAL, I moved it to strutils

@Araq
Copy link
Member

Araq commented Jan 31, 2020

I'll let people vote on this one. IMO it's pointless cruft and strutils is already too big too.

@liquidev
Copy link
Contributor

Don't we have strutils.escape already?

@Clyybber
Copy link
Contributor

And we have sugar.outplace for this kind of thing. We only need to assign it an operator IMO.

@Clyybber
Copy link
Contributor

Clyybber commented Jan 31, 2020

What could also work, is to introduce quoted and move the actual implementation from addQuoted to it.
Then we could deprecate addQuoted in favor of add quoted.

@timotheecour
Copy link
Member Author

with #13309 we'll be able to do:
"".@addQuoted("foo")

I will close this PR if #13309 gets merged

@timotheecour
Copy link
Member Author

actually the more I think of it the more I believe #13309 is the way to go. closing.

@timotheecour timotheecour changed the title new quoted: outplace version of addQuoted [superseded] new quoted: outplace version of addQuoted Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants