-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TODO] [WIP] new outplace operator without intermediate copies/temporaries #13337
Closed
timotheecour
wants to merge
12
commits into
nim-lang:devel
from
timotheecour:pr_outplace_operator_nocopy
Closed
[TODO] [WIP] new outplace operator without intermediate copies/temporaries #13337
timotheecour
wants to merge
12
commits into
nim-lang:devel
from
timotheecour:pr_outplace_operator_nocopy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replied here: #13309 (comment) ; no need to duplicate comments ;-) |
… into a release yet
timotheecour
force-pushed
the
pr_outplace_operator_nocopy
branch
from
February 9, 2020 08:38
2893636
to
c55aad8
Compare
See nim-lang/RFCs#192 for a discussion of the design. |
RFC is shipping. |
timotheecour
changed the title
[WIP] new outplace operator without intermediate copies/temporaries
[TODO] [WIP] new outplace operator without intermediate copies/temporaries
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review unless you want to help (eg concrete simpler implementation suggestion etc), but this seems to work well
Will eventually merge this into #13309, just a preview.
Implementation is more complex, which is the price to pay for generating efficient code: this avoids temporaries where possible; namely: consecutive elements in a
.>
chain generate a single temporary instead of 1 per element of the chain.example:
generates:
more examples: see unittests
still open questions
nnkIdent
), but that currently breaks for examples involving openArray, see D20200205T024841 in tests