Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specialize genericReset #14398

Merged
merged 6 commits into from
May 19, 2020
Merged

specialize genericReset #14398

merged 6 commits into from
May 19, 2020

Conversation

Araq
Copy link
Member

@Araq Araq commented May 19, 2020

No description provided.

@timotheecour
Copy link
Member

timotheecour commented May 19, 2020 •
edited
Loading

@Araq Araq merged commit b35d370 into devel May 19, 2020
@Araq Araq deleted the araq-special-reset branch May 19, 2020 19:42
@mratsim
Copy link
Collaborator

mratsim commented May 19, 2020 •
edited
Loading

@tersec had numbers also that showcase that genericReset showed up as as costly as cryptography in Nimbus (i.e. number 2 bottleneck after hashing).

If that fixes that performance regression, we would love to see that backported in 1.2.2 due to incoming audits.

@Araq
Copy link
Member Author

Araq commented May 20, 2020

@mratsim I know, that's why it was done.

narimiran pushed a commit that referenced this pull request May 20, 2020
@Araq @narimiran
specialize genericReset (#14398)
7800fa3 
* progress
* make tests green
* maybe we also want to reset pointers, dunno
* progress
* cleanup; fixes #13879 [backport:1.2]

(cherry picked from commit b35d370)
@timotheecour timotheecour mentioned this pull request May 22, 2020
Open
1 task
EchoPouet pushed a commit to EchoPouet/Nim that referenced this pull request Jun 13, 2020
@Araq @EchoPouet
specialize genericReset (nim-lang#14398)
d89ffc6 
* progress
* make tests green
* maybe we also want to reset pointers, dunno
* progress
* cleanup; fixes nim-lang#13879 [backport:1.2]
@Clyybber Clyybber mentioned this pull request Aug 11, 2020
Closed
@timotheecour timotheecour mentioned this pull request Apr 9, 2021
Open
@ringabout ringabout mentioned this pull request Jul 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Araq @timotheecour @mratsim